Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some code smells #1271

Merged
merged 31 commits into from
Nov 7, 2023
Merged

fix some code smells #1271

merged 31 commits into from
Nov 7, 2023

Conversation

qdraw
Copy link
Owner

@qdraw qdraw commented Nov 3, 2023

PR Details

Description / Motivation and Context

Related Issue

How Has This Been Tested

  • C# Unit tests
  • Typescript Unit tests
  • Other Unit tests
  • Manual tests
  • Automatic End2end tests (starsky-tools/end2end)

Types of changes

  • Added for new features
  • Breaking change fix or feature that would cause existing functionality to change
  • Changed for non-breaking changes in existing functionality for example docs change / refactoring / dependency upgrades
  • Deprecated for soon-to-be removed features
  • Removed for now removed features
  • Fixed for any bug fixes
  • Security in case of vulnerabilities

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation accordingly (update when needed)
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the ./history.md document

@codecov Codecov
Copy link

codecov bot commented Nov 3, 2023 •
edited
Loading

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (a2c59cf) 94.51% compared to head (63163db) 94.59%.
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1271      +/-   ##
==========================================
+ Coverage   94.51%   94.59%   +0.07%     
==========================================
  Files         567      571       +4     
  Lines       20157    20213      +56     
  Branches     3147     3176      +29     
==========================================
+ Hits        19052    19120      +68     
+ Misses        737      725      -12     
  Partials      368      368
Flag Coverage Δ
all 94.59% <91.86%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...y.foundation.http/Streaming/FileStreamingHelper.cs 100.00% <ø> (ø)
...ntapp/src/components/atoms/drop-area/drop-area.tsx 84.37% <100.00%> (ø)
...app/src/components/atoms/list-image/list-image.tsx 92.30% <100.00%> (ø)
...p/src/components/atoms/menu-option/menu-option.tsx 100.00% <100.00%> (ø)
...sky/clientapp/src/components/atoms/modal/modal.tsx 100.00% <100.00%> (ø)
...ntapp/src/components/atoms/more-menu/more-menu.tsx 100.00% <100.00%> (ø)
...debar/archive-sidebar-label-edit-add-overwrite.tsx 88.60% <100.00%> (ø)
...ebar/archive-sidebar-label-edit-search-replace.tsx 92.59% <100.00%> (ø)
...les/archive-sidebar/archive-sidebar-label-edit.tsx 100.00% <100.00%> (ø)
...archive-sidebar/archive-sidebar-selection-list.tsx 92.85% <100.00%> (+0.26%) ⬆️
... and 18 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

88.7% 88.7% Coverage
0.0% 0.0% Duplication

@qdraw qdraw merged commit f50e86c into master Nov 7, 2023
15 checks passed
@qdraw qdraw deleted the feature/202311_code_smells branch November 7, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@qdraw